Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow imports nested in packagings to shadow #21539

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Sep 4, 2024

Fixes #21405

So, before my change, importing java.lang.annotation and then importing
"annotation" will return java.lang.annotation, but complete as
scala.annotation - so the completion logic (in scopeCompletions) is
wrong somewhere.  After my change they both return java.lang.annotation,
so looks like I might have unintentionally made that logic work for this
case - just need to update the test expectation.
@dwijnand dwijnand marked this pull request as ready for review September 27, 2024 07:43
@dwijnand dwijnand assigned SethTisue and unassigned som-snytt Oct 30, 2024
@dwijnand dwijnand requested review from SethTisue and removed request for som-snytt October 30, 2024 10:11
@SethTisue SethTisue removed their assignment Nov 5, 2024
@dwijnand dwijnand merged commit 7f141a9 into scala:main Nov 6, 2024
28 checks passed
@dwijnand dwijnand deleted the shadow-import branch November 6, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import outside a package clause is not shadowed by an import inside the package clause
3 participants